In the learning process of Citizenship Education, it is necessary to have a reciprocal relationship between teachers and students, so that two-way communication is established which makes learning directed at achieving competence. Besides carrying out the learning process in an atmosphere of two-way communication, it is hoped that students can also do it in an atmosphere of multi-way communication.The student have question model is used to learn about the wishes and expectations of students as a basis for maximizing their potential. In the question students have learning model requires students to write down questions about subject matter that they do not understand in the form of sheets of paper, then give other friends the opportunity to read the existing questions. The purpose of this research is to know the cognitive learning outcomes and affective learning outcomes by usinglearningactive question type students have in learning Citizenship Education at SMA Manggala.This study used a quantitative approach with a quasi-experimental design at the X IPS (experimental class) and X IPS (control class) grades at Manggala Senior High School. The data collection techniques are: observation, tests, literature studies, and documentation studies. The results of this study indicate that the results of cognitive learningit was obtained that the average posttest score of students in class X IPA as an experimental class was greater than in the control class X IPS. The learning completeness of the students was 86.66% while the control class was 56.66%, while the effective learning results were obtained by the average attitude of students which consisted of three aspects indicating that the experimental class had a higher average compared to the control class on the aspect of activeness , cooperation and respect for the opinions of others. Thus it can be concluded learningactive question type student have can improve cognitive and affective learning outcomes in learning citizenship education at SMA Manggala.